[OGUI-1581] Split action for taking/releasing all locks in API router #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Endpoint to manage all detectors, enforce Global role.
should allow access for Global user on locks ALL. Expect Taken states
…ing/releasingalllocksinAPIrouter
This middleware will add the detectorid object to the requests
graduta
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Hi @pepijndik !
Very nice and quick PR, especially well done on the testing side!
I added a few minor comments for you to have a look and fix
…ing/releasingalllocksinAPIrouter
graduta
requested changes
Dec 2, 2024
graduta
requested changes
Dec 3, 2024
Control/test/lib/middleware/mocha-addDetectorId.middleware.test.js
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
graduta
requested changes
Dec 3, 2024
graduta
approved these changes
Dec 3, 2024
graduta
deleted the
feature/pepijndik/OGUI-1581/Splitactionfortaking/releasingalllocksinAPIrouter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Added middleware to append detectorid, and endpoint for action of all detectors